Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): fix dependency resolution #5859

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Conversation

leandrodamascena
Copy link
Contributor

Issue number: #5857

Summary

Changes

Some dependencies like boto3 depend on urllib and dependency resolution fails sometimes.

Some other dependencies like aws-requests-auth are bringing in requests as an optional dependency, but they are not pinning the minimum version of requests and are installing requests==0.14.0 which has a potential CVE. Even this does not affect customers, because it is a development dependency, it is important to fix.

User experience

No changes for customer experience.

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@leandrodamascena leandrodamascena requested a review from a team as a code owner January 13, 2025 15:58
@boring-cyborg boring-cyborg bot added the tests label Jan 13, 2025
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 13, 2025
@leandrodamascena leandrodamascena linked an issue Jan 13, 2025 that may be closed by this pull request
2 tasks
@github-actions github-actions bot added the internal Maintenance changes label Jan 13, 2025
@leandrodamascena leandrodamascena merged commit 1b81fbf into develop Jan 13, 2025
17 checks passed
@leandrodamascena leandrodamascena deleted the fix-dependencies-v2 branch January 13, 2025 16:01
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.17%. Comparing base (2364fb1) to head (a7d8911).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #5859   +/-   ##
========================================
  Coverage    96.17%   96.17%           
========================================
  Files          232      232           
  Lines        10941    10941           
  Branches      2023     2023           
========================================
  Hits         10522    10522           
  Misses         329      329           
  Partials        90       90           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Maintenance changes size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: Fix transitive dependency resolution
2 participants