Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(appsync): enhance consistency for custom resolver field naming in AppSync #5801

Merged
merged 2 commits into from
Dec 30, 2024

Conversation

leandrodamascena
Copy link
Contributor

Issue number: #5560

Summary

Changes

This PR aims to bring consistency to scenarios where customers want to use a custom resolver in AppSync to place fields outside of the info object while maintaining consistency by using the same field name parentTypeName.

  • Modified the logic to check for parentTypeName both inside and outside the info object
  • Implemented a fallback to typeName if parentTypeName is not found

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@leandrodamascena leandrodamascena requested a review from a team as a code owner December 27, 2024 16:45
@boring-cyborg boring-cyborg bot added the tests label Dec 27, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 27, 2024
@github-actions github-actions bot added the bug Something isn't working label Dec 27, 2024
@leandrodamascena leandrodamascena linked an issue Dec 27, 2024 that may be closed by this pull request
2 tasks
Copy link

codecov bot commented Dec 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.17%. Comparing base (0cbd1c1) to head (36c1ee6).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #5801   +/-   ##
========================================
  Coverage    96.17%   96.17%           
========================================
  Files          232      232           
  Lines        10940    10941    +1     
  Branches      2023     2023           
========================================
+ Hits         10521    10522    +1     
  Misses         329      329           
  Partials        90       90           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@anafalcao anafalcao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job @leandrodamascena ! approved

@anafalcao anafalcao merged commit 33b5a9c into develop Dec 30, 2024
13 checks passed
@anafalcao anafalcao deleted the fix-appsync-fields-order branch December 30, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: AppSyncResolverEvent uses typeName instead of parentTypeName
2 participants