-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(metrics): warn when overwriting dimension #5653
feat(metrics): warn when overwriting dimension #5653
Conversation
Signed-off-by: Ana Falcão <[email protected]>
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5653 +/- ##
========================================
Coverage 96.17% 96.17%
========================================
Files 231 231
Lines 10916 10920 +4
Branches 2018 2019 +1
========================================
+ Hits 10498 10502 +4
Misses 329 329
Partials 89 89 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for implementing this quickly!
Issue number:
#5638
Summary
Changes
When using dimensions with the Metrics class, the default behavior is to overwrite existing dimensions if a new dimension with the same name/key is added. To improve troubleshooting and prevent silent data loss, we've implemented a warning system that alerts users when dimension overwriting occurs.
User experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.