feat(data-classes): decode json_body if based64 encoded #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/XS
Codecov Report
@@ Coverage Diff @@
## develop #560 +/- ##
========================================
Coverage 99.86% 99.86%
========================================
Files 113 113
Lines 4485 4485
Branches 243 243
========================================
Hits 4479 4479
Misses 3 3
Partials 3 3
Continue to review full report at Codecov.
|
pull-request-size
bot
removed
the
size/XS
pull-request-size
bot
added
the
size/S
|
@heitorlessa it is a pretty small change, if you want to have a look |
|
Oh, I thought I did!! Thanks for the nudge |
heitorlessa
approved these changes
Jul 27, 2021
| @@ -65,7 +65,7 @@ def body(self) -> Optional[str]: | |||
| @property | |||
| def json_body(self) -> Any: | |||
There was a problem hiding this comment.
Should we fix the older type annotation you Dict[str, Any] here too?
There was a problem hiding this comment.
It could be a list too :)
|
Eer, true
…On Tue, 27 Jul 2021 at 06:33, Michael Brewer ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In aws_lambda_powertools/utilities/data_classes/common.py
<#560 (comment)>
:
> @@ -65,7 +65,7 @@ def body(self) -> Optional[str]:
@Property
def json_body(self) -> Any:
It could be a list too :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#560 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAZPQBGAS3YIQYPBJCZGSB3TZYZJHANCNFSM5A43S76A>
.
|
heitorlessa
changed the title
heitorlessa
added a commit
that referenced
this pull request
Jul 30, 2021
* develop: feat(params): expose high level max_age, raise_on_transform_error (#567) fix(parser): apigw wss validation check_message_id; housekeeping (#553) chore(deps-dev): bump isort from 5.9.2 to 5.9.3 (#574) feat(data-classes): decode json_body if based64 encoded (#560) chore(deps-dev): bump mkdocs-material from 7.2.0 to 7.2.1 (#566)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Use
decoded_bodyfor the body injson_body. This will allow for a json string that is base64 encoded to be decoded and parsed in one go.Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.