-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(idempotency): add support for Optional type when serializing output #5590
Conversation
Quality Gate passedIssues Measures |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5590 +/- ##
===========================================
- Coverage 96.18% 96.17% -0.02%
===========================================
Files 231 232 +1
Lines 10919 10940 +21
Branches 2019 2023 +4
===========================================
+ Hits 10502 10521 +19
- Misses 328 329 +1
- Partials 89 90 +1 ☔ View full report in Codecov by Sentry. |
Quality Gate passedIssues Measures |
Issue number: #5589
Summary
Changes
This Pull Request addresses an issue with the
PydanticSerializer
when used in conjunction with the idempotent_function decorator. Currently, the serializer does not support optional return types (Optional[T] or T | None), leading to errors when functions are designed to returnNone
.Example
Changes made to fix
PydanticSerializer
to recognize and accept optional return types.User experience
Customers can now use
None
as return type.Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.