-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(parser): change parser documentation #5262
docs(parser): change parser documentation #5262
Conversation
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
|
Hey @leandrodamascena ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @anafalcao! This is amazing to start reviewing this PR, indeed a great improvement in our documentation.
I see we have room to improve some areas and I left some comments. Can you please review and address them before we move to the next round of this review?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for the reviews @leandrodamascena ! Fixed your comments
Signed-off-by: Ana Falcão <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing to all the feedback, @anafalcao! I have some new comments in this second round!
Lets go!! We're almost ready to merge this PR.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5262 +/- ##
========================================
Coverage 96.16% 96.16%
========================================
Files 229 229
Lines 10810 10810
Branches 2007 2007
========================================
Hits 10395 10395
Misses 327 327
Partials 88 88 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @anafalcao! Congratulations on getting your first PR approved as a Powertools maintainer, this is a huge achievement in such a short time. I made a few small changes before approving it and let me tell you:
1 - We try to use active voice as much as possible, so in areas where you were saying "parser allows you to use XYZ", I changed it to "you can use XYZ in the parser utility".
2 - Some examples were importing things from Powertools instead of Pydantic, as it is better to import BaseModel directly from Pydantic than from Powertools, for example. Both work, but the customer can have more control over the imports.
3 - Mypy was complaining about some types, but don't worry, mypy is a nightmare sometimes.
4 - Some highlights were wrong and I fixed them.
Congratss!! 🚀 ⭐
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments.
Thanks a lot for the work on this PR!
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @dreamorosi! Thanks for such a detailed review, I pushed a new commit with the last few things before we merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @anafalcao, looking forward to see this merged.
We should probably bring these changes to the TS docs as well.
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
Issue number: #1371
Summary
This PR refreshes Parser docs with newer features like examples, improves wording and navigation, focused on Powertools v3.
Changes
User experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.