Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(batch): add from __future__ import annotations #4993

Merged
merged 4 commits into from
Aug 17, 2024

Conversation

ericbn
Copy link
Contributor

@ericbn ericbn commented Aug 15, 2024

Issue number: #4994

Summary

Changes

Add from __future__ import annotations to batch package

User experience

Discussed in #4607

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

and update code according to ruff rules TCH, UP006, UP007, UP037 and
FA100.
@ericbn ericbn requested a review from a team as a code owner August 15, 2024 18:26
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 15, 2024
Copy link
Contributor

@leandrodamascena leandrodamascena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ericbn! I reverted some changes that included Pydantic models and was failing in Pythoh 3.8/3.9. Can you check please?

Copy link

@ericbn
Copy link
Contributor Author

ericbn commented Aug 16, 2024

Given the latest findings, we need to make sure the old typing types are still being used in:

  1. Pydantic models
  2. Type aliases
  3. typing.cast calls

I’ll double check this until Monday.

EDIT: I also suggest we remove the from __future__ import annotations from files where it’s not needed.

@leandrodamascena
Copy link
Contributor

Given the latest findings, we need to make sure the old typing types are still being used in:

  1. Pydantic models
  2. Type aliases
  3. typing.cast calls

I’ll double check this until Monday.

EDIT: I also suggest we remove the from __future__ import annotations from files where it’s not needed.

Perfect! I've added the label do-not-merge.

@ericbn
Copy link
Contributor Author

ericbn commented Aug 17, 2024

I've reviewed all open PRs regarding the items we've listed above, and looks like we're all good.

@leandrodamascena leandrodamascena self-requested a review August 17, 2024 21:45
Copy link
Contributor

@leandrodamascena leandrodamascena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVED!

@leandrodamascena leandrodamascena merged commit 918844d into aws-powertools:v3 Aug 17, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge enhancement size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tech debt: add from __future__ import annotations in the Batch Processing feature
2 participants