-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(batch): add from __future__ import annotations #4993
Conversation
and update code according to ruff rules TCH, UP006, UP007, UP037 and FA100.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ericbn! I reverted some changes that included Pydantic models and was failing in Pythoh 3.8/3.9. Can you check please?
Quality Gate passedIssues Measures |
Given the latest findings, we need to make sure the old typing types are still being used in:
I’ll double check this until Monday. EDIT: I also suggest we remove the |
Perfect! I've added the label |
I've reviewed all open PRs regarding the items we've listed above, and looks like we're all good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
APPROVED!
Issue number: #4994
Summary
Changes
Add
from __future__ import annotations
to batch packageUser experience
Discussed in #4607
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.