refactor(data_classes): add from __future__ import annotations #4939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and update code according to ruff rules TCH, UP006, UP007, UP037 and FA100.
pull-request-size
bot
added
the
size/XL
2 tasks
|
This is the last one left @ericbn!! I hope to review and merge this tomorrow morning 🙏 |
|
leandrodamascena
approved these changes
Aug 19, 2024
There was a problem hiding this comment.
And we finally reached the end of this journey of refactoring the codebase to comply with some Python PEPs and Ruff! Awesome work @ericbn, we've been wanting to pay off this tech debt for a while! Thank you so much for putting so much effort into this!
➜ aws-lambda-powertools-python git:(data_classes_annotations) ✗ poetry run ruff check --exclude "aws_lambda_powertools/utilities/parser/models/*" --select FA100 --isolated aws_lambda_powertools
All checks passed!APPROVED!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #4958
Summary
Changes
Add
from __future__ import annotationsto data_classes packageUser experience
Discussed in #4607
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.