Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add token to codecov action #4682

Merged

Conversation

hjgraca
Copy link
Contributor

@hjgraca hjgraca commented Jul 3, 2024

Issue number: #4681

Summary

Codecov upload is failing on non fork pull requests as per documentation
image

Changes

⚠️ Before merging this pull request, CODECOV_TOKEN environment variable must be present in GitHub settings

Add token parameter to codecov action, as per the documentation https://about.codecov.io/blog/january-product-update-updating-the-codecov-ci-uploaders-to-the-codecov-cli/

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@hjgraca hjgraca requested a review from a team as a code owner July 3, 2024 10:47
@boring-cyborg boring-cyborg bot added the github-actions Pull requests that update Github_actions code label Jul 3, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 3, 2024
@github-actions github-actions bot added the internal Maintenance changes label Jul 3, 2024
Copy link
Contributor

@leandrodamascena leandrodamascena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hjgraca! ❤️

@leandrodamascena leandrodamascena merged commit 5d437cd into aws-powertools:develop Jul 3, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github-actions Pull requests that update Github_actions code internal Maintenance changes size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants