-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(user-agent): support patching botocore session #2614
chore(user-agent): support patching botocore session #2614
Conversation
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## develop #2614 +/- ##
===========================================
- Coverage 97.23% 97.18% -0.05%
===========================================
Files 161 161
Lines 7415 7431 +16
Branches 538 538
===========================================
+ Hits 7210 7222 +12
- Misses 158 162 +4
Partials 47 47
☔ View full report in Codecov by Sentry. |
Hi @roger-zhangg thank you for opening this PR. According to our contributing guide an opened issue is required before you submit a PR. Can you please check if you can create one so we can triage it? |
#2626 |
Looking into this today |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing reason why we need this
Signed-off-by: Roger Zhang <[email protected]>
Signed-off-by: Roger Zhang <[email protected]>
Issue number:
#2626
Support patching botocore for data-masking
Summary
Changes
Add
register_feature_to_botocore_session
toshared.user_agent
User experience
No UX impact
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.