Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps-dev): bump mypy from 1.1.1 to 1.2.0 #2096

Merged
merged 3 commits into from
Apr 11, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 6, 2023

Bumps mypy from 1.1.1 to 1.2.0.

Commits
  • 4f47dfb Promote version to 1.2.0 and drop +dev from the version
  • 06aa182 [dataclass_transform] support implicit default for "init" parameter in field ...
  • 7beaec2 Support descriptors in dataclass transform (#15006)
  • a7a995a Multiple inheritance considers callable objects as subtypes of functions (#14...
  • 7f2a5b5 [dataclass_transform] fix deserialization for frozen_default
  • bfa9eac [mypyc] Be stricter about function prototypes (#14942)
  • 4e6d683 [mypyc] Document native floats and integers (#14927)
  • aa2679b [mypyc] Fixes to float to int conversion (#14936)
  • 9944d5f [mypyc] Support iterating over a TypedDict (#14747)
  • 1a8ea61 [mypyc] Avoid boxing/unboxing when coercing between tuple types (#14899)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from a team as a code owner April 6, 2023 21:11
@dependabot dependabot bot requested review from heitorlessa and removed request for a team April 6, 2023 21:11
@dependabot dependabot bot added dependencies Pull requests that update a dependency file python Pull requests that update Python code labels Apr 6, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 6, 2023
@github-actions github-actions bot added the internal Maintenance changes label Apr 6, 2023
@dependabot dependabot bot force-pushed the dependabot/pip/develop/mypy-1.2.0 branch 3 times, most recently from 683af47 to 08d02ca Compare April 7, 2023 21:08
@leandrodamascena leandrodamascena requested review from leandrodamascena and removed request for heitorlessa April 10, 2023 10:38
@dependabot dependabot bot force-pushed the dependabot/pip/develop/mypy-1.2.0 branch 2 times, most recently from 12aa1f2 to 36300be Compare April 10, 2023 11:13
Bumps [mypy](https://github.com/python/mypy) from 1.1.1 to 1.2.0.
- [Release notes](https://github.com/python/mypy/releases)
- [Commits](python/mypy@v1.1.1...v1.2.0)

---
updated-dependencies:
- dependency-name: mypy
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/pip/develop/mypy-1.2.0 branch from 36300be to 81a6a2f Compare April 10, 2023 21:22
@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 11, 2023
Not supported on python 3.7
@rubenfonseca
Copy link
Contributor

@leandrodamascena ready for review. Typeshed was updated with big changes to the underlying IO types, that's why we had to extend the signatures to support it.

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (907c80d) 97.46% compared to head (2092201) 97.46%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2096   +/-   ##
========================================
  Coverage    97.46%   97.46%           
========================================
  Files          147      147           
  Lines         6798     6798           
  Branches       483      483           
========================================
  Hits          6626     6626           
  Misses         136      136           
  Partials        36       36           
Impacted Files Coverage Δ
..._powertools/utilities/streaming/_s3_seekable_io.py 89.47% <100.00%> (ø)
...lambda_powertools/utilities/streaming/s3_object.py 74.68% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@leandrodamascena leandrodamascena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
The new function signature makes me a little confused with so many parameters, but it seems we have no choice but to use that signature or add ignore comments. Of course it's best to keep the type checking according to what mypy asks for.

@leandrodamascena leandrodamascena merged commit b57f521 into develop Apr 11, 2023
@leandrodamascena leandrodamascena deleted the dependabot/pip/develop/mypy-1.2.0 branch April 11, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file internal Maintenance changes python Pull requests that update Python code size/M Denotes a PR that changes 30-99 lines, ignoring generated files. streaming
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants