Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): remove additional quotes in PR action #1317

Conversation

heitorlessa
Copy link
Contributor

Issue number: #1009

Summary

Changes

Please provide a summary of what's being changed

Removes possible additional quotes from GH Actions env to ensure conditional logic matches actual value.

Example of a new PR that wasn't labelled correctly: #1316

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 19, 2022
@github-actions github-actions bot added the bug Something isn't working label Jul 19, 2022
@heitorlessa heitorlessa merged commit d440e99 into aws-powertools:develop Jul 19, 2022
@heitorlessa heitorlessa deleted the chore/fix-double-escape-constants branch July 19, 2022 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants