Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): lockdown 3rd party workflows to pin sha #1301

Merged

Conversation

heitorlessa
Copy link
Contributor

@heitorlessa heitorlessa commented Jul 14, 2022

Issue number: #1009

Summary

Changes

Please provide a summary of what's being changed

This PR increases our security posture following an older malicious token leak from codecov workflow (addressed last year). This guarantees that any change to GitHub Actions workflows that include or update 3rd party actions use pin to their respective git sha, thus making it an immutable use.

Official docs: https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions#using-third-party-actions

User experience

Please share what the user experience looks like before and after this change

As a maintainer, we should see the following error when non-compliant:

image

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 14, 2022
@boring-cyborg boring-cyborg bot added the github-actions Pull requests that update Github_actions code label Jul 14, 2022
@github-actions github-actions bot added the internal Maintenance changes label Jul 14, 2022
@heitorlessa heitorlessa requested a review from rubenfonseca July 14, 2022 14:50
@heitorlessa heitorlessa self-assigned this Jul 14, 2022
@pull-request-size pull-request-size bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github-actions Pull requests that update Github_actions code internal Maintenance changes size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants