Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(logger): exclude source_logger in copy_config_to_registered_loggers #1001

Merged
merged 2 commits into from
Feb 4, 2022

Conversation

houbie
Copy link
Contributor

@houbie houbie commented Feb 4, 2022

#999

Description of changes:

The source_logger was not added correctly to the exclusions.

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 4, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Feb 4, 2022

Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need.

@heitorlessa heitorlessa changed the title bug: fix exclusion of source_logger in copy_config_to_registered_loggers fix(logger): correctly exclude source_logger in copy_config_to_registered_loggers Feb 4, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2022

Codecov Report

Merging #1001 (8b61e39) into develop (168ec48) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1001   +/-   ##
========================================
  Coverage    99.96%   99.96%           
========================================
  Files          119      119           
  Lines         5347     5347           
  Branches       610      610           
========================================
  Hits          5345     5345           
  Partials         2        2           
Impacted Files Coverage Δ
aws_lambda_powertools/logging/utils.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 168ec48...8b61e39. Read the comment docs.

@github-actions github-actions bot added the bug Something isn't working label Feb 4, 2022
@heitorlessa
Copy link
Contributor

@houbie thank you so much for fixing it so quickly! <3

@heitorlessa heitorlessa changed the title fix(logger): correctly exclude source_logger in copy_config_to_registered_loggers fix(logger): exclude source_logger in copy_config_to_registered_loggers Feb 4, 2022
@heitorlessa heitorlessa merged commit 1b7f248 into aws-powertools:develop Feb 4, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Feb 4, 2022

Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants