Static analysis spotbugs #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pankajagrawal16
force-pushed
the
static-analysis-spotbugs
branch
8 times, most recently
from
f930cdf to
85f3469
Compare
pankajagrawal16
force-pushed
the
static-analysis-spotbugs
branch
from
85f3469 to
60d85d3
Compare
pankajagrawal16
force-pushed
the
static-analysis-spotbugs
branch
from
60d85d3 to
b204d3f
Compare
msailes
reviewed
Jul 6, 2021
pankajagrawal16
commented
Jul 6, 2021
| @@ -85,8 +85,13 @@ public void setSchemaVersion(SpecVersion.VersionFlag version) { | |||
| * @param <T> Must extends {@link BaseFunction} | |||
| */ | |||
| public <T extends BaseFunction> void addFunction(T function) { | |||
| configuration.functionRegistry().extend(function); | |||
| jmesPath = new JacksonRuntime(configuration, getObjectMapper()); | |||
| FunctionRegistry functionRegistryWithExtendedFunctions = configuration.functionRegistry().extend(function); | |||
There was a problem hiding this comment.
This was a neat finding and was actually a bug
pankajagrawal16
commented
Jul 6, 2021
|
|
||
| if (schema.startsWith(CLASSPATH)) { | ||
| String filePath = schema.substring(CLASSPATH.length()); | ||
| try (InputStream schemaStream = ValidationAspect.class.getResourceAsStream(filePath)) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
It will display failed checks like this. PR fixes all the spotbugs identified issues as well.
Checklist
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.