Get Sha256 Checksum for Release Artifacts #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majanjua-amzn
previously approved these changes
Nov 8, 2024
|
A few questions:
Happy to sync up on this. |
harrryr
force-pushed
the
add-checksum
branch
7 times, most recently
from
c7193c8 to
32d4fec
Compare
harrryr
changed the title
srprash
reviewed
Dec 10, 2024
harrryr
force-pushed
the
add-checksum
branch
4 times, most recently
from
6f0311d to
82bc923
Compare
harrryr
changed the title
harrryr
force-pushed
the
add-checksum
branch
3 times, most recently
from
fd7498e to
bd4d094
Compare
srprash
previously approved these changes
Dec 17, 2024
majanjua-amzn
previously approved these changes
Dec 17, 2024
harrryr
force-pushed
the
add-checksum
branch
from
bfdfee9 to
f8372f8
Compare
harrryr
force-pushed
the
add-checksum
branch
2 times, most recently
from
734a8ec to
2146f09
Compare
harrryr
force-pushed
the
add-checksum
branch
from
2146f09 to
d3a9ccd
Compare
majanjua-amzn
previously approved these changes
Dec 17, 2024
.github/workflows/release_build.yml
Outdated
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| run: | | ||
| filename="aws_opentelemetry_distro-${{ github.event.inputs.version }}-py3-none-any.whl" |
There was a problem hiding this comment.
nit: filename is used in more than one place, could be worth setting it to an environment variable for reuse to avoid any mistakes in the future
srprash
reviewed
Dec 17, 2024
harrryr
force-pushed
the
add-checksum
branch
3 times, most recently
from
6a5e57b to
f88c154
Compare
harrryr
force-pushed
the
add-checksum
branch
from
f88c154 to
53fff0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
We want to provide the checksum of release artifact to customers.
Description of changes:
When new artifact is released through
release_build.yml, get the sha256 checksum of the artifact then attach it to the release note as a.sha256fileExample: Release Note
Testing
Workflow run: https://github.com/harrryr/aws-otel-python-instrumentation/actions/runs/12384286607
Verified that the .sha256 has the correct content and running
shasum -a 256 -c <artifact_name>.sha256returns the output<artifact_name>: OKBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.