Add AwsSpanProcessingUtil #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thpierce
force-pushed
the
mag
branch
2 times, most recently
from
cf7c2b5 to
5d6bbdb
Compare
zzhlogin
reviewed
Jan 11, 2024
aws-opentelemetry-distro/src/amazon/opentelemetry/distro/_aws_span_processing_util.py
Outdated
Show resolved
Hide resolved
zzhlogin
reviewed
Jan 11, 2024
aws-opentelemetry-distro/src/amazon/opentelemetry/distro/_aws_span_processing_util.py
Show resolved
Hide resolved
AwsSpanProcessingUtil is a utility module designed to support shared logic across AWS Span Processors. This is a roughly-carbon-copy file of https://github.com/aws-observability/aws-otel-java-instrumentation/blob/main/awsagentprovider/src/main/java/software/amazon/opentelemetry/javaagent/providers/AwsSpanProcessingUtil.java
zzhlogin
approved these changes
Jan 11, 2024
mxiamxia
pushed a commit
that referenced
this pull request
Dec 16, 2024
*Issue #, if available:* Our recent PR builds for Python are failing with: ``` #16 3.705 error: failed to compile `cargo-audit v0.21.0`, intermediate artifacts can be found at `/tmp/cargo-installzAcK49`. #16 3.705 To reuse those artifacts with a future compilation, set the environment variable `CARGO_TARGET_DIR` to that path. #16 3.705 #16 3.705 Caused by: #16 3.705 package `home v0.5.11` cannot be built because it requires rustc 1.81 or newer, while the currently active rustc version is 1.75.0 #16 3.705 Try re-running cargo install with `--locked` #16 ERROR: process "/bin/sh -c if [ $TARGETARCH = \"amd64\" ]; then cargo install cargo-audit && cargo audit ; fi" did not complete successfully: exit code: 101 #15 [build 5/5] RUN mkdir workspace && pip install --target workspace ./aws-opentelemetry-distro #15 4.601 Collecting opentelemetry-instrumentation-pymemcache==0.48b0 (from aws-opentelemetry-distro==0.7.0.dev0) #15 4.614 Downloading opentelemetry_instrumentation_pymemcache-0.48b0-py3-none-any.whl.metadata (1.9 kB) #15 4.657 Collecting opentelemetry-instrumentation-pymongo==0.48b0 (from aws-opentelemetry-distro==0.7.0.dev0) #15 4.674 Downloading opentelemetry_instrumentation_pymongo-0.48b0-py3-none-any.whl.metadata (1.9 kB) ``` *Description of changes:* Bumping the version of rustc to `1.81` in our Dockerfile. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AwsSpanProcessingUtil is a utility module designed to support shared logic across AWS Span Processors. This is a roughly-carbon-copy file of https://github.com/aws-observability/aws-otel-java-instrumentation/blob/main/awsagentprovider/src/main/java/software/amazon/opentelemetry/javaagent/providers/AwsSpanProcessingUtil.java
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.