Update patch of upstream OTel Python otel-instrument script #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanielRN
force-pushed
the
update-python-otel-instrument-patch
branch
from
70ac179 to
dcb0613
Compare
NathanielRN
commented
Oct 28, 2021
Comment on lines
+125
to
+129
|
|
||
| if [ -z ${OTEL_PROPAGATORS} ]; then | ||
| export OTEL_PROPAGATORS="tracecontext,baggage,xray"; | ||
| fi |
There was a problem hiding this comment.
This line is the only line that is different with the otel-instrument script on opentelemetry-lambda upstream
Upstream we say:
# - Uses the default `OTEL_PROPAGATORS` which is set to `tracecontext,baggage`
There was a problem hiding this comment.
Can you just have this line and then call the upstream otel-instrument script?
It's not the cleanest way, but removes the need to maintain duplicate scripts so we use that approach in the other exec wrappers
https://github.com/aws-observability/aws-otel-lambda/blob/main/java/build.sh#L27
https://github.com/aws-observability/aws-otel-lambda/blob/main/java/scripts/otel-handler#L13
There was a problem hiding this comment.
Thanks for this! I made #163 to try and implement what you suggested! 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
With the upstream open-telemetry/opentelemetry-lambda#164 merged, we want to update our patched version to be very similar.
It only has the difference that it adds the
xraypropagator.Link to tracking Issue:
N/A
Testing:
N/A
Documentation:
N/A