Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove otel-instrument-est wraper #103

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Conversation

mxiamxia
Copy link
Member

@mxiamxia mxiamxia commented Oct 11, 2024

Issue #, if available:

Description of changes:
Follow changes on #101.

Instead of using a otel-instrument-esm wrapper which is redudent, we will have customer to use HANDLER_IS_ESM env var to enforce ESM instrumentation for the failed to detected cases.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@mxiamxia mxiamxia marked this pull request as ready for review October 11, 2024 17:26
@mxiamxia mxiamxia requested a review from a team as a code owner October 11, 2024 17:26
@mxiamxia mxiamxia merged commit c09824f into aws-observability:main Oct 11, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants