temp: Comment out ECR-related release steps #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majanjua-amzn
added
java
srprash
reviewed
Jul 18, 2024
srprash
approved these changes
Jul 18, 2024
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## release/v1.32.x #847 +/- ##
==================================================
Coverage ? 78.13%
Complexity ? 244
==================================================
Files ? 15
Lines ? 718
Branches ? 120
==================================================
Hits ? 561
Misses ? 129
Partials ? 28 ☔ View full report in Codecov by Sentry. |
majanjua-amzn
added a commit
that referenced
this pull request
Jul 22, 2024
revert: Uncomment release steps that were commented in #847
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 1.32.3 release failed to publish non-K8s/EKS related artifacts. As such, we will temporarily comment these out while working to resolve the authentication issues for the Maven artifacts that are not being published. In this way, we will only perform the failed steps and their prerequisite steps on the next attempt, so as to not change the image digest of the ECRs that have already been published.
Changing a github workflow file will NOT impact the released artifacts.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.