Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the cert-manager CSI driver #945

Merged
merged 3 commits into from
Sep 14, 2022

Conversation

bobdoah
Copy link
Contributor

@bobdoah bobdoah commented Sep 9, 2022

The cert-manager CSI driver can be used to generate and attach certificates and private keys directly to pods.

What does this PR do?

Add the Cert Manager CSI driver. Closes #950

Motivation

I would like to use this, with Cert Manager as it makes generating and mounting certificates for mTLS very easy.

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs require a new example and/or doc page. In general:

  • Use an existing example when possible to demonstrate a new addons usage
  • A new docs page under docs/add-ons/* is required for new a new addon

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

Copy link
Contributor

@askulkarni2 askulkarni2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bobdoah PR is looking good, minor typos in the doc.

For future, we would love to see an issue first for any significant work - we would hate for your time to be wasted. I've opened #442 for now.

docs/add-ons/cert-manager-csi-driver.md Outdated Show resolved Hide resolved
@askulkarni2
Copy link
Contributor

@bobdoah any thoughts on updating the ACM PCA example we have to show the CSI driver in use?

The cert-manager CSI driver can be used to generate and attach
certificates and private keys directly to pods.
@bobdoah
Copy link
Contributor Author

bobdoah commented Sep 13, 2022

@bobdoah any thoughts on updating the ACM PCA example we have to show the CSI driver in use?

@askulkarni2 I updated the eks-cluster-with-new-vpc, but can update that example too, if desired.

@bobdoah bobdoah temporarily deployed to EKS Blueprints Test September 13, 2022 08:42 Inactive
@askulkarni2 askulkarni2 temporarily deployed to EKS Blueprints Test September 14, 2022 06:06 Inactive
Copy link
Contributor

@askulkarni2 askulkarni2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the PR.

@askulkarni2 askulkarni2 merged commit 54e81c8 into aws-ia:main Sep 14, 2022
allamand pushed a commit to allamand/terraform-aws-eks-blueprints that referenced this pull request Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ADDON] Cert Manager CSI driver
2 participants