Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for
kyverno
addon including reporter UI and baseline policies #910feat: Add support for
kyverno
addon including reporter UI and baseline policies #910Changes from 16 commits
ba0c389
370e75e
7d34127
ead7b3e
76b28df
44b037e
ced53dc
e250fc8
ceb2f71
a368d80
2cfab04
8322d64
dfaaf14
f35e558
9e08362
b1cf0d2
befc323
22a1e01
e6e7891
dcb09ae
3a1707f
a4cb0e6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove this text
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can remove this default values file - I don't see any improvements over the upstream defaults other than using
restricted
standard overbaseline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
restricted
have some necessary policies which are used by most sites. It is harmless to leave this file for customization.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since there are only charts for
kyverno
andkyverno-policies
, we should remove this additionalkyverno-ui
component and match the upstream project https://docs.aws.amazon.com/eks/latest/userguide/launch-templates.htmlusers can pass in the appropriate values to enable the UI component through the
kyverno
moduleThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, ok now I see - they split out a separate project https://github.com/kyverno/policy-reporter/tree/main/charts/policy-reporter
we should keep the names consistent and instead call this
kyverno-policy-reporter
throughoutThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we will need to:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created a PR for this which applies the items above: aws-samples/eks-blueprints-add-ons#83