-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(aws-ebs-csi-driver): add capability to deploy into self managed mode #896
Feat(aws-ebs-csi-driver): add capability to deploy into self managed mode #896
Conversation
…d-capability-to-deploy-self-addon
Thank you for creating this PR, but I do not see any related issue/s to this PR. |
Hello, Thank you for your feedback, I was going to create an issue but I saw that an issue already existed for a problem similar to mine. I have just added the issue to my PR. Does this look right to you? |
examples/aws-ebs-csi-driver-self-managed/helm_values/aws-ebs-csi-driver.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use #558 as a reference since it follows the same pattern. Note that we'll need to add more documentation around the two different routes users can use to deploy this addon, etc.
…d-capability-to-deploy-self-addon
Hello @bryantbiggs . |
Co-authored-by: Bryant Biggs <[email protected]>
Co-authored-by: Bryant Biggs <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution @jmenan !
…mode (aws-ia#896) Co-authored-by: Bryant Biggs <[email protected]> Co-authored-by: j_menan <[email protected]>
What does this PR do?
Closes #577
add capability to deploy aws-ebs-csi-driver addon into self managed mode
Motivation
Currently the
aws-ebs-csi-driver
managed addon does not allow any configuration changes.For example, deploying
aws-ebs-csi-driver
on "tainted" nodes is not supported and this can be problematic in some cases.Until the modification of the addon in EKS managed mode is possible, I propose to be able to deploy "ans-ebs-csi-driver" in self managed mode with its helm chart
More
pre-commit run -a
with this PRNote: Not all the PRs required examples and docs except a new pattern or add-on added.
For Moderators
Additional Notes