Add calico to Kubernetes addon #885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florentio
requested review from
askulkarni2,
kcoleman731,
vara-bonthu,
bryantbiggs and
Zvikan
as code owners
florentio
force-pushed
the
feat/calico-addon
branch
from
17d893b
to
f3c7e34
Compare
bryantbiggs
reviewed
Aug 27, 2022
bryantbiggs
reviewed
Aug 27, 2022
bryantbiggs
reviewed
Aug 27, 2022
bryantbiggs
reviewed
Aug 27, 2022
bryantbiggs
reviewed
Aug 27, 2022
There was a problem hiding this comment.
Looks great - few minor comments.
Once we merge #885 - lets update this PR to add the addon to that example to demonstrate and validate its usage
bryantbiggs
reviewed
Aug 27, 2022
bryantbiggs
reviewed
Aug 27, 2022
bryantbiggs
reviewed
Aug 27, 2022
bryantbiggs
reviewed
Aug 27, 2022
bryantbiggs
reviewed
Aug 27, 2022
There was a problem hiding this comment.
Few updates from testing. Per https://docs.aws.amazon.com/eks/latest/userguide/calico.html we should install tigera-operator and when I tried with the PR as it is currently, it fails to find the chart/install.
Good catch. I am going to fix it. Thanks |
bryantbiggs
approved these changes
Aug 27, 2022
allamand
pushed a commit
to allamand/terraform-aws-eks-blueprints
that referenced
this pull request
Dec 15, 2022
Co-authored-by: Bryant Biggs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds the Calico Helm chart to the Kubernetes addons.
Motivation
My company are in the process of adopting calico for networking and network security solution for our EKS cluster. This addon would be a useful addon for us to deploy to our clusters.
Also there is already an issue ticket on the roadmap related to it #436
More
pre-commit run -awith this PRNote: Not all the PRs required examples and docs except a new pattern or add-on added.
For Moderators
Additional Notes