Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use eks 1.23 #860

Closed
wants to merge 1 commit into from
Closed

chore: use eks 1.23 #860

wants to merge 1 commit into from

Conversation

kahirokunn
Copy link
Contributor

@kahirokunn kahirokunn commented Aug 16, 2022

What does this PR do?

🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs required examples and docs except a new pattern or add-on added.

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@kahirokunn kahirokunn temporarily deployed to EKS Blueprints Test August 16, 2022 07:16 Inactive
@Zvikan
Copy link
Contributor

Zvikan commented Aug 18, 2022

Thank you @kahirokunn , we should do proper end to end testing using our GH workflow, I may need to recreate this PR as of today we can run this workflow only against local branches which are not public forks (unless someone knows quick and easy way to do it).

I sent a message to the team to see if anyone started testing and validating, if not i'll take ownership and run this workflow on separate branch, heads up, we'll probably have to switch to separate PR because of the branch change.

@kahirokunn
Copy link
Contributor Author

@Zvikan
Okay 👌
Is there anything I can do to help?

@Zvikan
Copy link
Contributor

Zvikan commented Aug 26, 2022

Closing this as #899 was created and tested using our E2E workflow, thanks again @kahirokunn !

@Zvikan Zvikan closed this Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants