Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/set argocd helm value types explicitly #856

Merged
merged 2 commits into from
Aug 15, 2022
Merged

Fix/set argocd helm value types explicitly #856

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b36d31d
Setting type explicitly on helm values for ArgoCD helm release
vignirhafsteinsson Aug 15, 2022
5e9f4ec
format fix
vignirhafsteinsson Aug 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions modules/kubernetes-addons/argocd/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,32 +29,38 @@ resource "helm_release" "argocd_application" {
set {
name = "name"
value = each.key
type = "string"
}

set {
name = "project"
value = each.value.project
type = "string"
}

# Source Config.
set {
name = "source.repoUrl"
value = each.value.repo_url
type = "string"
}

set {
name = "source.targetRevision"
value = each.value.target_revision
type = "string"
}

set {
name = "source.path"
value = each.value.path
type = "string"
}

set {
name = "source.helm.releaseName"
value = each.key
type = "string"
}

set {
Expand All @@ -65,12 +71,14 @@ resource "helm_release" "argocd_application" {
local.global_application_values,
each.value.add_on_application ? var.addon_config : {}
))
type = "auto"
}

# Destination Config.
set {
name = "destination.server"
value = each.value.destination
type = "string"
}

depends_on = [module.helm_addon]
Expand Down