-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update templates provided to aid in collaboration and following the process #844
Conversation
@@ -1,23 +1,30 @@ | |||
--- | |||
name: Feature request | |||
about: Suggest an idea for this project | |||
title: '[FEATURE] <title>' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we use labels so no need for the templated [FEATURE]
|
||
### Community Note | ||
|
||
* Please vote on this issue by adding a 👍 [reaction](https://blog.github.com/2016-03-10-add-reactions-to-pull-requests-issues-and-comments/) to the original issue to help the community and maintainers prioritize this request |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pinched from Terraform AWS provider - just a more explicit statement of what we want users to do in terms of crowdsourcing feature request priority
|
||
## Reproduction Code [Required] | ||
|
||
<!-- REQUIRED --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hard requirement, HARD requirement
|
||
<!-- REQUIRED --> | ||
|
||
Steps to reproduce the behavior: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very important as well - these two pieces give us the closes representation of a reproduction
.github/PULL_REQUEST_TEMPLATE.md
Outdated
### What does this PR do? | ||
|
||
<!-- A brief description of the change being made with this pull request. --> | ||
- [ ] ✋ I am aware of the [CONTRIBUTING](https://github.com/aws-ia/terraform-aws-eks-blueprints/blob/main/CONTRIBUTING.md#contributing-via-pull-requests) guide for submitting pull-requests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets see if this helps reinforce the practice to flesh out details through issues first before committing to a large body of code in a PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting this together @bryantbiggs!
What does this PR do?
Motivation
More
pre-commit run -a
with this PRNote: Not all the PRs required examples and docs except a new pattern or add-on added.
For Moderators
Additional Notes