-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ec2:DescribeImages to karpenter IAM to support v0.14 #807
add ec2:DescribeImages to karpenter IAM to support v0.14 #807
Conversation
Signed-off-by: Fernando Miguel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets wait for 0.14 to be released and update the karpenter example to demonstrate this new functionality and verify the permissions are correct
it's in the module, not the example. |
A rc is out for testing Sadly I'm off on annual leave and unable to test anytime soon, prior to release. |
This is now released https://github.com/aws/karpenter/releases/tag/v0.14.0 Would you mind updating the default addon version to point to this latest release, then we can merge this. We can also include #836 in this PR as well, thanks! |
@bryantbiggs I'll pick this up tomorrow. |
version is released and we can proceed
|
Signed-off-by: Fernando Miguel <[email protected]>
@bryantbiggs ready for review |
Its a one line change, I think its ok to add it here |
up to you :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update!
Co-authored-by: Bryant Biggs <[email protected]>
Signed-off-by: Fernando Miguel [email protected]
What does this PR do?
Adds
ec2:DescribeImages
to karpenter IAM policyMotivation
Karpenter v0.14 will require a new permission
https://github.com/aws/karpenter/pull/2169/files#diff-7c5cd36388230ea106cff266bf0ab314b88b940b523b5acf523746f7baa496b7R117
More
pre-commit run -a
with this PRNote: Not all the PRs required examples and docs except a new pattern or add-on added.
For Moderators
Additional Notes