-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add example for VPC-CNI custom networking #778
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dope PR, thank you! should we add this example to our E2E workflow as it'll be a common example by many users IMO.
To teardown and remove the resources created in this example: | ||
|
||
```sh | ||
terraform destroy -auto-approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Single TF destroy works without any known ENI dangling issues?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, but let me update to align with what we've been recommending
# VPC-CNI Custom Networking ENIConfig | ||
#--------------------------------------------------------------- | ||
|
||
resource "kubectl_manifest" "eni_config" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does it matter the order of this resource? should the manifest come first right after the cluster is created AND before the addons?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes order matters - the VPC CNI needs to be updated and the ENIConfig present before nodes are ready. However, since custom networking should be set at cluster creation, the order of operations work out as is naturally
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome stuff!
} | ||
spec = { | ||
securityGroups = [ | ||
module.eks_blueprints.cluster_primary_security_group_id, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in my testing, i cant get this to work if there are more than one SG in the ENIConfig
What does this PR do?
terraform-aws-eks
module to v18.26.3 which is latest - update is to allow use of dedicated control plane subnets which are recommended for expanding data plane without cluster disruptionMotivation
More
pre-commit run -a
with this PRNote: Not all the PRs required examples and docs except a new pattern or add-on added.
For Moderators
Additional Notes