-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addon kube prometheus stack #765
Conversation
…form-aws-eks-blueprints into addon-kube-prometheus-stack
Overall, looks great @alanty - just a few questions since I'm not familiar with the chart or intentions and haven't tested locally yet |
Co-authored-by: Bryant Biggs <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @alanty for this PR 👍🏼
I have few minor comments on this PR.
updates from review after testing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏼 Thanks Alan 🚀
* init new module with empty files * init helm addon * create module parameters * use underscores not dashes * add default values.yaml file for chart * add actual values to values.yaml * remove commented AMP items * update documentation * update docs * pre-commit cleanup * add docs for kube-prometheus-stack * Apply suggestions from code review Co-authored-by: Bryant Biggs <[email protected]> * remove comments from review * Update modules/kubernetes-addons/kube-prometheus-stack/README.md * review and comment cleanup * add persistent storage for prometheus server * doc cleanup, adminPassword example Co-authored-by: Bryant Biggs <[email protected]>
What does this PR do?
Adds kube-prometheus-stack helm chart as a kubernetes add-on.
Motivation
There are existing addons for Prometheus, and Grafana. This installs both, a collection of useful dashboards, and the Prometheus Operator CRDs in one solution.
More
pre-commit run -a
with this PRNote: Not all the PRs required examples and docs except a new pattern or add-on added.
For Moderators
Additional Notes