Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: iamlive in csm mode #763

Merged
merged 1 commit into from
Jul 12, 2022
Merged

fix: iamlive in csm mode #763

merged 1 commit into from
Jul 12, 2022

Conversation

Zvikan
Copy link
Contributor

@Zvikan Zvikan commented Jul 12, 2022

What does this PR do?

  • Changes Iamlive to run in CSM mode instead of Proxy

Motivation

  • Some actions may fail in proxy mode, as of now we set wildcard for resource with a big warning, and it is possible to run terraform with CSM with this change.

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs required examples and docs except a new pattern or add-on added.

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@Zvikan Zvikan temporarily deployed to EKS Blueprints Test July 12, 2022 15:07 Inactive
vara-bonthu
vara-bonthu approved these changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Zvikan Zvikan merged commit 6a1e412 into main Jul 12, 2022
@Zvikan Zvikan deleted the iamlive-csm-mode branch July 12, 2022 15:47
allamand pushed a commit to allamand/terraform-aws-eks-blueprints that referenced this pull request Dec 15, 2022
@Zvikan @allamand
fix: iamlive in csm mode (aws-ia#763)
47aaf2e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vara-bonthu vara-bonthu vara-bonthu approved these changes

@askulkarni2 askulkarni2 Awaiting requested review from askulkarni2

@kcoleman731 kcoleman731 Awaiting requested review from kcoleman731

@bryantbiggs bryantbiggs Awaiting requested review from bryantbiggs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zvikan @vara-bonthu