-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add upstream module with k8s-addons example #698
Conversation
eks_cluster_id = module.eks.cluster_id | ||
eks_cluster_endpoint = module.eks.cluster_endpoint | ||
eks_oidc_provider = module.eks.oidc_provider | ||
eks_cluster_version = module.eks.cluster_version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really the most important part of this example, should we call this out in the README/add a comment here?
# EKS Cluster with terraform-aws-eks module | ||
#--------------------------------------------------------------- | ||
|
||
module "eks" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried to keep the example as simple as possible, if you believe we can further remove more pieces here lmk.
looks good - general question, is |
Agree and forgot to call it out, but I first tried to call it terraform-aws-eks... but having long name example leads to issues with IRSA/IAM resources names that may be limited to 64 chars :( |
vpc_id = module.vpc.vpc_id | ||
subnet_ids = module.vpc.private_subnets | ||
|
||
eks_managed_node_group_defaults = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this example should be an upstream module rather than a blueprint.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vara-bonthu customers want to see how kubernetes-addons module can be used with upstream.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
vpc_id = module.vpc.vpc_id | ||
subnet_ids = module.vpc.private_subnets | ||
|
||
eks_managed_node_group_defaults = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vara-bonthu customers want to see how kubernetes-addons module can be used with upstream.
What does this PR do?
Motivation
More
pre-commit run -a
with this PRNote: Not all the PRs required examples and docs except a new pattern or add-on added.
For Moderators
Additional Notes