-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MWAA module and example #585
Conversation
…role and role-binding native resources
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for much needed PR 👍🏼 Few minor comments.
I haven't tested this myself. Please add the testing evidence to this PR.
@maiconrocha Please update this PR to point to new MWAA module |
@maiconrocha Could you please update this PR as discussed? |
|
…orking as expected
@vara-bonthu I have update example to use mwaa module on the registry, it is tested and working as expected |
@maiconrocha I'm going to make a few updates but we should be able to get this merged today - thank you again for this contribution! |
examples/mwaa/main.tf
Outdated
|
||
eks_cluster_id = module.eks_blueprints.eks_cluster_id | ||
|
||
enable_metrics_server = false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we want these enabled or should we just skip the addons for this example? I haven't delved into MWAA but seems like we'd want some autoscaling to support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for now I'm enabling them but we can always adjust the example in subsequent PRs
Updates made and validated in 7b8663d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this addition @maiconrocha and the module contribution 🎉
Co-authored-by: Bryant Biggs <[email protected]>
What does this PR do?
Demonstrates how to use Amazon Managed Workflows for Apache Airflow (MWAA) with Amazon EKS.
This example was originated from the steps provided on MWAA documentation on the link below:
mwaa-eks-example
Also, I have added a module to provision Amazon Managed Workflows for Apache Airflow (MWAA).
Motivation
Close #441
As an AWS Employee with experience with EKS, Terraform and MWAA, I want to provide an example to customers in how to use Amazon Managed Workflows for Apache Airflow (MWAA) with Amazon EKS.
More
pre-commit run -a
with this PRNote: Not all the PRs required examples and docs except a new pattern or add-on added.
For Moderators
Additional Notes
Test Evidence showing the pod was schedule successfully by MWAA:
kubectl get pods -n mwaa
NAME READY STATUS RESTARTS AGE
mwaa-pod-test.2816b0b5b01047af947768d5cd6b889b 0/1 Completed 0 31s