-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support cluster_security_group_tags and node_security_group_tags #557
Conversation
All checks are now Green :) |
Thanks @armujahid - are there additional changes to be made in this PR? Looking at the information provided above, specifically:
|
@bryantbiggs This PR is complete from my side. I will do karpenter example changes in a separate PR. |
Can we include those changes here so we show the motivation behind adding the additional tags? |
Sure. I will push changes here. |
Currenly default provsioner uses both node_security_group and cluster_security_group which causes issues with ingress controllers
pushed :) |
Checks are now green after merging main. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @armujahid !
What does this PR do?
This PR adds
cluster_security_group_tags
and node_security_group_tags support.I just propagated both variables to https://registry.terraform.io/modules/terraform-aws-modules/eks/aws/latest
Motivation
Nginx (and AWS load balancer) controller expects one security group in Node otherwise this error is thrown
Currently If we run karpenter example with nginx then we get this error because
kubernetes.io/cluster/${eks-cluster-id}: owned
returns two security groups:References:
kubernetes.io/cluster/$name
kubernetes-sigs/aws-load-balancer-controller#2367More
pre-commit run -a
with this PRNote: Not all the PRs required examples and docs except a new pattern or add-on added.
For Moderators
Additional Notes
I will also update karpenter example in next PR to use
"karpenter.sh/discovery" = local.cluster_name
security group selector in provisioner belownode_security_group_tags
will also be added in "eks_blueprints" module block to avoid any issue with Nginx.