feat: Add support for AppMesh controller addon with AppMesh mTLS example #539

svelango · 2022-05-12T14:39:55Z

What does this PR do?

Adds AppMesh Addon

Motivation

Closes tickets as much as possible

More

[ X] Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
Yes, I have added a new example under examples to support my PR
Yes, I have created another PR for add-ons under add-ons repo (if applicable)
[X ] Yes, I have updated the docs for this feature
Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs required examples and docs except a new pattern or add-on added.

For Moderators

E2E Test successfully complete before merge?

Additional Notes

kcoleman731

Looks great. Thank you for the PR! Minor comments for you.

README.md

modules/kubernetes-addons/aws-app-mesh/locals.tf

modules/kubernetes-addons/aws-app-mesh/variables.tf

askulkarni2

@svelango thanks for the PR. We will need some additional things:

For gitops mode, please open another PR here. See other addons for example for what's needed.
Add documentation under docs
Add a detailed example under examples to demonstrate a non-trivial usage of the add-on.
Provide some information in the PR comments on how this was tested.

vara-bonthu

Thanks for the PR @svelango Few minor comments needs incorporating and the comments from @kcoleman731

We also need a docs page for this Add-on here https://github.com/aws-ia/terraform-aws-eks-blueprints/tree/main/docs/add-ons. Refer to the other Add-ons as an example
Update the PR with your test results for this add-on.

modules/kubernetes-addons/main.tf

modules/kubernetes-addons/variables.tf

modules/kubernetes-addons/aws-app-mesh/locals.tf

github-actions · 2022-06-28T00:01:59Z

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

github-actions · 2022-08-07T00:02:26Z

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

Zvikan · 2022-08-10T13:47:19Z

@svelango any updates on this?

svelango · 2022-08-12T15:55:21Z

The examples directory is there. Need to see why build failed. Checking.

…ueprints into main

svelango · 2022-08-22T14:41:39Z

@svelango is ACM PCA required for AppMesh mTLS or can folks use cert-manager as the CA? If we can demonstrate this with cert-manager I think that would make the example more applicable to a broader audience and also easier for folks to get up and running with.

Ref: aws/aws-app-mesh-roadmap#34

@bryantbiggs Picked ACM as we are adding ACM addon into EKS so as a example added a sample for ACM.

bryantbiggs · 2022-08-27T13:41:19Z

@svelango is ACM PCA required for AppMesh mTLS or can folks use cert-manager as the CA? If we can demonstrate this with cert-manager I think that would make the example more applicable to a broader audience and also easier for folks to get up and running with.
Ref: aws/aws-app-mesh-roadmap#34

@bryantbiggs Picked ACM as we are adding ACM addon into EKS so as a example added a sample for ACM.

Lets use cert-manager here please

svelango · 2022-09-02T16:26:23Z

@svelango is ACM PCA required for AppMesh mTLS or can folks use cert-manager as the CA? If we can demonstrate this with cert-manager I think that would make the example more applicable to a broader audience and also easier for folks to get up and running with.
Ref: aws/aws-app-mesh-roadmap#34

@bryantbiggs Picked ACM as we are adding ACM addon into EKS so as a example added a sample for ACM.

Lets use cert-manager here please

hi @bryantbiggs If I understand we wanted to use Cert-Manager and ACM PCA as Issuer and not directly work with ACM to get certificate?

github-actions · 2022-10-03T00:03:53Z

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

github-actions · 2022-10-13T00:04:05Z

Pull request closed due to inactivity.

allamand

There is not output from terraform, so how can we connect to the cluster ?

Also It missing some Readme with guidance on how to uses this AppMesh add-on with a simple example to follow

allamand · 2022-10-26T15:51:19Z

README.md

+# Deploy Kubernetes Add-ons with sub module
+#--------------------------------------------
+module "eks-blueprints-kubernetes-addons" {
+    source = "github.com/aws-ia/terraform-aws-eks-blueprints//modules/kubernetes-addons"


we should specify version here

allamand · 2022-10-26T15:51:35Z

README.md

+    enable_ingress_nginx                  = true
+    enable_appmesh_controller             = true
+
+    depends_on = [module.eks-blueprints.managed_node_groups]


depend_on is not recommended with modules

…ple (#539) Co-authored-by: Elango Sundararajan <[email protected]> Co-authored-by: Bryant Biggs <[email protected]>

…ple (aws-ia#539) Co-authored-by: Elango Sundararajan <[email protected]> Co-authored-by: Bryant Biggs <[email protected]>

Adding AppMesh Addon

813402e

svelango requested review from askulkarni2, kcoleman731, vara-bonthu, bryantbiggs and Zvikan as code owners May 12, 2022 14:39

kcoleman731 reviewed May 12, 2022

View reviewed changes

askulkarni2 reviewed May 16, 2022

View reviewed changes

vara-bonthu reviewed May 26, 2022

View reviewed changes

From Origin

17bd5a7

svelango had a problem deploying to EKS Blueprints Test May 28, 2022 18:33 Failure

Elango Sundararajan and others added 2 commits May 28, 2022 14:06

Merge remote-tracking branch 'upstream/main' into main

2142e0d

Code Review Comments

3c57a9f

svelango had a problem deploying to EKS Blueprints Test May 28, 2022 19:21 Failure

github-actions bot added stale and removed stale labels Jun 28, 2022

Merge branch 'main' into main

19077cb

bryantbiggs had a problem deploying to EKS Blueprints Test July 7, 2022 20:21 Failure

github-actions bot added the stale label Aug 7, 2022

github-actions bot removed the stale label Aug 11, 2022

bryantbiggs self-assigned this Aug 11, 2022

Merge branch 'main' into main

40a81eb

bryantbiggs had a problem deploying to EKS Blueprints Test August 11, 2022 17:48 Error

askulkarni2 mentioned this pull request Aug 11, 2022

[ADDON] - AppMesh #437

Closed

Merge branch 'main' of https://github.com/aws-ia/terraform-aws-eks-bl…

fb42583

…ueprints into main

svelango had a problem deploying to EKS Blueprints Test August 12, 2022 16:24 Error

svelango had a problem deploying to EKS Blueprints Test August 15, 2022 17:05 Error

svelango force-pushed the main branch from 0b6ebb3 to 376db9f Compare August 17, 2022 15:35

svelango had a problem deploying to EKS Blueprints Test August 17, 2022 15:36 Error

Updated Examples With new Changes

4157e16

svelango force-pushed the main branch from 376db9f to 4157e16 Compare August 17, 2022 15:54

svelango had a problem deploying to EKS Blueprints Test August 17, 2022 15:54 Error

Merge branch 'main' of https://github.com/aws-ia/terraform-aws-eks-bl…

f0aac5a

…ueprints into main

svelango had a problem deploying to EKS Blueprints Test August 22, 2022 14:42 Failure

github-actions bot added the stale label Oct 3, 2022

github-actions bot closed this Oct 13, 2022

bryantbiggs reopened this Oct 25, 2022

bryantbiggs had a problem deploying to EKS Blueprints Test October 25, 2022 23:56 Error

bryantbiggs removed the stale label Oct 25, 2022

allamand requested changes Oct 26, 2022

View reviewed changes

Merge branch 'main' of github.com:aws-ia/terraform-aws-eks-blueprints

2196833

bryantbiggs requested a review from csantanapr as a code owner October 28, 2022 15:23

bryantbiggs had a problem deploying to EKS Blueprints Test October 28, 2022 15:23 Error

chore: Update to align with current standards

c23cb44

bryantbiggs temporarily deployed to EKS Blueprints Test October 28, 2022 18:40 Inactive

bryantbiggs changed the title ~~Adding AppMesh Addon~~ feat: Add support for AppMesh controller addon with AppMesh mTLS example Oct 28, 2022

bryantbiggs approved these changes Oct 28, 2022

View reviewed changes

bryantbiggs merged commit 3a16188 into aws-ia:main Oct 28, 2022

vara-bonthu pushed a commit that referenced this pull request Nov 11, 2022

feat: Add support for AppMesh controller addon with AppMesh mTLS exam…

4227a4c

…ple (#539) Co-authored-by: Elango Sundararajan <[email protected]> Co-authored-by: Bryant Biggs <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add support for AppMesh controller addon with AppMesh mTLS example #539

feat: Add support for AppMesh controller addon with AppMesh mTLS example #539

svelango commented May 12, 2022 •

edited

Loading

kcoleman731 left a comment

askulkarni2 left a comment

vara-bonthu left a comment

github-actions bot commented Jun 28, 2022

github-actions bot commented Aug 7, 2022

Zvikan commented Aug 10, 2022

svelango commented Aug 12, 2022

svelango commented Aug 22, 2022

bryantbiggs commented Aug 27, 2022

svelango commented Sep 2, 2022

github-actions bot commented Oct 3, 2022

github-actions bot commented Oct 13, 2022

allamand left a comment

allamand Oct 26, 2022

allamand Oct 26, 2022

feat: Add support for AppMesh controller addon with AppMesh mTLS example #539

feat: Add support for AppMesh controller addon with AppMesh mTLS example #539

Conversation

svelango commented May 12, 2022 • edited Loading

What does this PR do?

Motivation

More

For Moderators

Additional Notes

kcoleman731 left a comment

Choose a reason for hiding this comment

askulkarni2 left a comment

Choose a reason for hiding this comment

vara-bonthu left a comment

Choose a reason for hiding this comment

github-actions bot commented Jun 28, 2022

github-actions bot commented Aug 7, 2022

Zvikan commented Aug 10, 2022

svelango commented Aug 12, 2022

svelango commented Aug 22, 2022

bryantbiggs commented Aug 27, 2022

svelango commented Sep 2, 2022

github-actions bot commented Oct 3, 2022

github-actions bot commented Oct 13, 2022

allamand left a comment

Choose a reason for hiding this comment

allamand Oct 26, 2022

Choose a reason for hiding this comment

allamand Oct 26, 2022

Choose a reason for hiding this comment

svelango commented May 12, 2022 •

edited

Loading