-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated the example for the private eks cluster with additional details and individual stacks for vpc, eks cluster and add-ons #388
Conversation
This following command used to update the `kubeconfig` in your local machine where you run kubectl commands to interact with your EKS Cluster. | ||
|
||
#### Step5: Run `update-kubeconfig` command | ||
Here is the high level design of the solution. The solution has been split into 3 different TerraForm stacks for simplicity. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Terraform
enable_vpa = true | ||
enable_yunikorn = false | ||
enable_argo_rollouts = false | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extra line. Also add-ons default to false so feel free to omit add-ons no used.
@@ -0,0 +1,116 @@ | |||
/* | |||
* Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copyright headers not needed
} | ||
} | ||
|
||
data "aws_region" "current" {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
put in a data.tf file for consistency
public_subnet_ids = data.terraform_remote_state.vpc_s3_backend.outputs.public_subnets | ||
|
||
cluster_name = join("-", [local.tenant, local.environment, local.zone, "eks"]) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extran line
subnet_ids = local.private_subnet_ids | ||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a new line
default = {} | ||
} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extra line
create = true | ||
vpc_id = module.aws_vpc.vpc_id | ||
security_group_ids = [ | ||
data.aws_security_group.default.id] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
format
output "public_subnets" { | ||
description = "List of IDs of public subnets" | ||
value = module.aws_vpc.public_subnets | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great some nit comments for you. Please connect with @Zvikan on adding this into e2e tests.
@kcoleman731 - Pushed updates based on review comments. |
This reverts commit ef790b4.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address the minor comments otherwise its ready to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the PR @satveerkhurpa.
…ls and individual stacks for vpc, eks cluster and add-ons (aws-ia#388)
fix: Add missing try entries in IDE environment variable block
What does this PR do?
This PR updates the example to provision a private eks cluster. The updates includes individual terraform stacks to set up the VPC, the eks cluster and add-ons. also includes a high level design that shows the users on how they can use a jenkins host or a bastion host from the default vpc, a peering connection between the default vpc and the eks vpc to complete the set up of the private eks cluster.
Motivation
Users will have an example to provision a private eks cluster the right way.
More
pre-commit run -a
with this PRNote: Not all the PRs required examples and docs except a new pattern or add-on added.
For Moderators
Additional Notes