Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/remove depends on and input examples from gh e2e workflow #365

Merged
merged 2 commits into from
Mar 24, 2022

Conversation

Zvikan
Copy link
Contributor

@Zvikan Zvikan commented Mar 24, 2022

What does this PR do?

  • Remove examples that require input vars
  • Remove depends_on from new-vpc example

Motivation

  • with latest upgrade to upstream version, we can't use depends_on on main accelerator module due to changes with the upstream EKS module - see here for more info
  • Remove examples that require input vars, currently GH e2e workflow does not support those examples.

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs required examples and docs except a new pattern or add-on added.

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

Copy link
Contributor

@kcoleman731 kcoleman731 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@Zvikan Zvikan merged commit 206354c into main Mar 24, 2022
@askulkarni2 askulkarni2 deleted the fix/remove-depends-on-and-input-examples branch March 31, 2022 18:47
alidonmez pushed a commit to alidonmez/terraform-aws-eks-blueprints-1 that referenced this pull request Mar 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants