-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Managed node group example with all the options #322
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, minor change to refactor relative pathing of examples on other doc files due to the folder name changes.
Please note, after merging this, customers who will future pull changes may be confused as from their end the previous folders may stay around (due to TF state saved locally on previous folder names).
I believe there's no way around it, proper change log communication will do the job.
…erraform/modules/cluster/hashicorp/helm-2.9.0 Bump hashicorp/helm from 2.8.0 to 2.9.0 in /terraform/modules/cluster
What does this PR do?
Motivation
More
pre-commit run -a
with this PRNote: Not all the PRs required examples and docs except a new pattern or add-on added.
For Moderators
Additional Notes