Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Managed node group example with all the options #322

Merged
merged 7 commits into from
Mar 9, 2022

Conversation

vara-bonthu
Copy link
Contributor

@vara-bonthu vara-bonthu commented Mar 6, 2022

What does this PR do?

  • New Managed node group example with all the options
  • Renamed existing examples

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs required examples and docs except a new pattern or add-on added.

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@vara-bonthu vara-bonthu self-assigned this Mar 6, 2022
Copy link
Contributor

@kcoleman731 kcoleman731 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Zvikan Zvikan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor change to refactor relative pathing of examples on other doc files due to the folder name changes.
Please note, after merging this, customers who will future pull changes may be confused as from their end the previous folders may stay around (due to TF state saved locally on previous folder names).
I believe there's no way around it, proper change log communication will do the job.

examples/windows-node-groups/README.md Show resolved Hide resolved
examples/managed-node-groups/README.md Outdated Show resolved Hide resolved
examples/managed-node-groups/main.tf Show resolved Hide resolved
examples/managed-node-groups/main.tf Show resolved Hide resolved
@vara-bonthu vara-bonthu merged commit a9e9d39 into main Mar 9, 2022
@vara-bonthu vara-bonthu deleted the example-managed-nodes branch March 9, 2022 10:10
alidonmez pushed a commit to alidonmez/terraform-aws-eks-blueprints-1 that referenced this pull request Mar 25, 2023
…erraform/modules/cluster/hashicorp/helm-2.9.0

Bump hashicorp/helm from 2.8.0 to 2.9.0 in /terraform/modules/cluster
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants