-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor vpa to use helm-addon module #300
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Few comments requires change 👍🏼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Just verify @vara-bonthu comments.
* Terraform provider jet aws * Crossplane Terrajet provider added * precommit format update * Crospslane examples updated * terraform-docs: automated action * crossplane docs updated * corssplane module docs updated * precommit format update * Mermaid flow design for Crossplane deployment * Readme type fix * removed time reosurce and added wait to cplane resource * data resources moved to root module * terraform-docs: automated action * Added tags to crossplane addon * Added note for iam policy Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Addon for the EFS CSI driver * Misc updates * Generate with terraform-docs * Naming convention * Add a blank line * Remove unused aws_region * Change markers for terraform-docs * Disable SA creation as it's handled by the IRSA module * Change version * Node SA doesn't apply to this version * Add example for EFS * Expand example * Remove test file * Remove prompt to make commands copy&paste friendly * Re-add fargate profile * Name convention changes * Only mention TF output once * Override SA name * Update chart version and handle node SA too * Encrypt the storage * Use the new approach as per Vara's review * Re-generate docs * Remove values.yaml as its whole contents are already set via set_values * Add empty line at the end of the file * Include a docs entry for the AWS EFS CSI driver * Add doc for the AWS EFS CSI driver * Expand description * Generalise policy name for both controller and node * Add EFS CSI driver entries * Add further steps to test provisioning * Correct destroy command option * Fix the SG definition to match mount target CIDR blocks * Remove extra spaces * Changes made by pre-commit * Remove Helm config items that match defaults; also use default timeout * Changes made by pre-commit * Rename example folder to aws-efs-csi-driver Co-authored-by: Luigi Di Fraia <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @vara-bonthu please review in the AM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! One change required
What does this PR do?
Refactor VPA addon to use the helm-addon module.
Motivation
Standardize addons.
More
pre-commit run -a
with this PRNote: Not all the PRs required examples and docs except a new pattern or add-on added.
For Moderators
Additional Notes