refactor vpa to use helm-addon module #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vara-bonthu
requested changes
Mar 2, 2022
kcoleman731
reviewed
Mar 2, 2022
* Terraform provider jet aws * Crossplane Terrajet provider added * precommit format update * Crospslane examples updated * terraform-docs: automated action * crossplane docs updated * corssplane module docs updated * precommit format update * Mermaid flow design for Crossplane deployment * Readme type fix * removed time reosurce and added wait to cplane resource * data resources moved to root module * terraform-docs: automated action * Added tags to crossplane addon * Added note for iam policy Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Addon for the EFS CSI driver * Misc updates * Generate with terraform-docs * Naming convention * Add a blank line * Remove unused aws_region * Change markers for terraform-docs * Disable SA creation as it's handled by the IRSA module * Change version * Node SA doesn't apply to this version * Add example for EFS * Expand example * Remove test file * Remove prompt to make commands copy&paste friendly * Re-add fargate profile * Name convention changes * Only mention TF output once * Override SA name * Update chart version and handle node SA too * Encrypt the storage * Use the new approach as per Vara's review * Re-generate docs * Remove values.yaml as its whole contents are already set via set_values * Add empty line at the end of the file * Include a docs entry for the AWS EFS CSI driver * Add doc for the AWS EFS CSI driver * Expand description * Generalise policy name for both controller and node * Add EFS CSI driver entries * Add further steps to test provisioning * Correct destroy command option * Fix the SG definition to match mount target CIDR blocks * Remove extra spaces * Changes made by pre-commit * Remove Helm config items that match defaults; also use default timeout * Changes made by pre-commit * Rename example folder to aws-efs-csi-driver Co-authored-by: Luigi Di Fraia <[email protected]>
kcoleman731
reviewed
Mar 3, 2022
vara-bonthu
requested changes
Mar 3, 2022
vara-bonthu
approved these changes
Mar 3, 2022
kcoleman731
approved these changes
Mar 3, 2022
Zvikan
approved these changes
Mar 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Refactor VPA addon to use the helm-addon module.
Motivation
Standardize addons.
More
pre-commit run -awith this PRNote: Not all the PRs required examples and docs except a new pattern or add-on added.
For Moderators
Additional Notes