Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Prometheus helm chart to 15.3.0 #260

Merged
merged 3 commits into from
Feb 17, 2022
Merged

Conversation

naris-silpakit
Copy link
Contributor

What does this PR do?

  • Updates the Prometheus helm chart to 15.3.0
  • Updates the image tags to latest in readme example.
  • Updates the selected version in the example in the Prometheus documentation.

More

Note: Not all the PRs required examples and docs except a new pattern or add-on added.

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

Testing notes:

  • created test directory and filled main.tf file with vpc, eks cluster with Prometheus and Amazon Managed Prometheus enabled
  • ran terraform apply -auto-approve and checked that deployment completes
  • connected to cluster and verified that nodes are online in prometheus namespace
  • checked prometheus pod logs to make sure there are no errors
  • connect to prometheus dashboard with kubectl port-forward $(kubectl get pods --namespace=prometheus --selector='component=server' --output=name) 8080:9090 -n prometheus to verify it loads

… in Prometheus readme to latest; update Prometheus helm chart version to 15.3.0 in documentation example
Copy link
Contributor

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! One change required

@@ -3,7 +3,7 @@ locals {
name = "prometheus"
chart = "prometheus"
repository = "https://prometheus-community.github.io/helm-charts"
version = "14.6.0"
version = "15.3.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@naris-silpakit Could you please find the all the occurrences of the Prometheus version and replace it? Some of the examples are also using the older version of Prometheus.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep! I'll do that and push an update.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@naris-silpakit please mark this as resolved once you have addressed @vara-bonthu's comment.

Copy link
Contributor

@askulkarni2 askulkarni2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, waiting for comment to be addressed.

@@ -3,7 +3,7 @@ locals {
name = "prometheus"
chart = "prometheus"
repository = "https://prometheus-community.github.io/helm-charts"
version = "14.6.0"
version = "15.3.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@naris-silpakit please mark this as resolved once you have addressed @vara-bonthu's comment.

Copy link
Contributor

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vara-bonthu vara-bonthu merged commit 74a3654 into main Feb 17, 2022
@vara-bonthu vara-bonthu deleted the feature/update-prometheus branch February 17, 2022 16:30
alidonmez pushed a commit to alidonmez/terraform-aws-eks-blueprints-1 that referenced this pull request Mar 25, 2023
…erraform/modules/cluster/terraform-aws-modules/rds/aws-5.2.3

Bump terraform-aws-modules/rds/aws from 5.2.1 to 5.2.3 in /terraform/modules/cluster
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants