Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add conditions for teams resources #254

Merged
merged 2 commits into from
Feb 16, 2022
Merged

fix: add conditions for teams resources #254

merged 2 commits into from
Feb 16, 2022

Conversation

Zvikan
Copy link
Contributor

@Zvikan Zvikan commented Feb 14, 2022

What does this PR do?

  • Adds conditions to teams module and resources, so they'll be created only when needed

Motivation

  • Recent reports shows teams resources are created even when teams variables are not passed.

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs required examples and docs except a new pattern or add-on added.

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

vara-bonthu
vara-bonthu approved these changes Feb 15, 2022
View reviewed changes
Copy link
Contributor

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kcoleman731
kcoleman731 reviewed Feb 15, 2022
View reviewed changes
Copy link
Contributor

@kcoleman731 kcoleman731 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Zvikan Zvikan merged commit eb0efb0 into main Feb 16, 2022
@Zvikan Zvikan deleted the fix/teams-resources branch February 17, 2022 15:05
alidonmez pushed a commit to alidonmez/terraform-aws-eks-blueprints-1 that referenced this pull request Mar 25, 2023
@niallthomson
Merge pull request aws-ia#254 from aws-samples/dependabot/npm_and_yar…
1320172 
…n/test/util/typescript-4.9.4

Bump typescript from 4.9.3 to 4.9.4 in /test/util
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcoleman731 kcoleman731 kcoleman731 left review comments

@vara-bonthu vara-bonthu vara-bonthu approved these changes

@askulkarni2 askulkarni2 Awaiting requested review from askulkarni2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Zvikan @kcoleman731 @vara-bonthu