Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Karpenter example with default provisioner #248

Merged
merged 4 commits into from
Feb 11, 2022
Merged

Conversation

vara-bonthu
Copy link
Contributor

@vara-bonthu vara-bonthu commented Feb 11, 2022

What does this PR do?

  • This example shows a pattern on how to deploy multiple Karpenter Cluster Autoscaler Provisioners

Motivation

  • Users feedback on Karpenter to manage provisioners using Terraform

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs required examples and docs except a new pattern or add-on added.

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes


NOTE: Make sure you delete all the deployments which clean up the nodes spun up by Karpenter Autoscaler
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an important thing to discuss. Terraform does not address the drift when using Karpenter.

Copy link
Contributor Author

@vara-bonthu vara-bonthu Feb 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's why I added this note to the users.
We should be ok as Terraform only cares about Node groups created by TF. It will not have any drift issues with Karpenter nodes as these are not joining the existing node groups.

Karpenter Nodes can only be deleted when we delete the deployments.

examples/karpenter/main.tf Show resolved Hide resolved
Copy link
Contributor

@askulkarni2 askulkarni2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@vara-bonthu vara-bonthu merged commit ee7468c into main Feb 11, 2022
@vara-bonthu vara-bonthu deleted the karpenter-example branch February 21, 2022 09:43
alidonmez pushed a commit to alidonmez/terraform-aws-eks-blueprints-1 that referenced this pull request Mar 25, 2023
…n/website/fortawesome/fontawesome-svg-core-6.2.1

Bump @fortawesome/fontawesome-svg-core from 6.2.0 to 6.2.1 in /website
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants