-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Karpenter example with default provisioner #248
Conversation
|
||
NOTE: Make sure you delete all the deployments which clean up the nodes spun up by Karpenter Autoscaler |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an important thing to discuss. Terraform does not address the drift when using Karpenter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's why I added this note to the users.
We should be ok as Terraform only cares about Node groups created by TF. It will not have any drift issues with Karpenter nodes as these are not joining the existing node groups.
Karpenter Nodes can only be deleted when we delete the deployments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
…n/website/fortawesome/fontawesome-svg-core-6.2.1 Bump @fortawesome/fontawesome-svg-core from 6.2.0 to 6.2.1 in /website
What does this PR do?
Motivation
More
pre-commit run -a
with this PRNote: Not all the PRs required examples and docs except a new pattern or add-on added.
For Moderators
Additional Notes