Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add eks-efa example #1594

Merged
merged 16 commits into from
May 15, 2023
Merged

feat: Add eks-efa example #1594

merged 16 commits into from
May 15, 2023

Conversation

iankouls-aws
Copy link
Contributor

What does this PR do?

This PR adds an example blueprint for an EKS cluster with EFA-enabled self-managed node group.
All changes are contained within the examples/eks-efa directory. Full documentation is added in the README file, including description of the template and an end-to-end walkthrough of creating the cluster and verifying the proper operation of Elastic Fabric Adapter.

Motivation

No end-to-end example for creating EFA-enabled EKS cluster using Terraform was available. Creating such infrastructure is a common need in the ML/AI and HPC communities. Being able to do that using a blueprint, would help the communities easily bootstrap projects with this capability.

More

  • [ x ] Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have updated the docs for this feature
    • Checked and there was nothing to update
  • [ x ] Yes, I ran pre-commit run -a with this PR

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

All pre-commit checks passed except tfsec validation

@iankouls-aws iankouls-aws requested a review from a team as a code owner May 9, 2023 05:17
@iankouls-aws iankouls-aws changed the title Add eks-efa example feat: Add eks-efa example May 9, 2023
@iankouls-aws iankouls-aws temporarily deployed to EKS Blueprints Test May 10, 2023 01:28 — with GitHub Actions Inactive
Copy link
Contributor

@askulkarni2 askulkarni2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! LGTM!

@askulkarni2 askulkarni2 merged commit a56919d into aws-ia:main May 15, 2023
gminiba pushed a commit to gminiba/terraform-aws-eks-blueprints that referenced this pull request May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Elastic Fabric Adapter
2 participants