Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Nodegroup update_default_version config should be parameterized #1590

Merged
merged 5 commits into from
May 6, 2023
Merged

feat: Nodegroup update_default_version config should be parameterized #1590

merged 5 commits into from
May 6, 2023

Conversation

jj-mino
Copy link
Contributor

@jj-mino jj-mino commented May 5, 2023

What does this PR do?

Parameterize update_default_version launch template config so nodegroups are not automatically updated on a version change
#1589

Motivation

Allow more control over Prod maintenance activities

  • Resolves #

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@jj-mino jj-mino requested a review from a team as a code owner May 5, 2023 21:45
@jj-mino jj-mino changed the title Patch 1 Nodegroup update_default_version config should be parameterized May 5, 2023
@jj-mino jj-mino changed the title Nodegroup update_default_version config should be parameterized Nodegroup update_default_version config should be parameterized May 5, 2023
@jj-mino jj-mino changed the title Nodegroup update_default_version config should be parameterized feat: Nodegroup update_default_version config should be parameterized May 5, 2023
@bryantbiggs bryantbiggs temporarily deployed to EKS Blueprints Test May 6, 2023 23:20 — with GitHub Actions Inactive
@bryantbiggs bryantbiggs merged commit df164e9 into aws-ia:main May 6, 2023
gminiba pushed a commit to gminiba/terraform-aws-eks-blueprints that referenced this pull request May 26, 2023
@jj-mino jj-mino deleted the patch-1 branch July 31, 2023 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants