Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Update teams multi-tenancy example to use new module #1549

Merged
merged 2 commits into from
Apr 11, 2023
Merged

refactor: Update teams multi-tenancy example to use new module #1549

merged 2 commits into from
Apr 11, 2023

Conversation

bryantbiggs
Copy link
Contributor

What does this PR do?

  • Update teams multi-tenancy example to use new module

Motivation

  • Removes dependency on local teams module in favor of new, independently published teams module

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@bryantbiggs bryantbiggs requested a review from a team as a code owner April 11, 2023 16:57
@bryantbiggs bryantbiggs temporarily deployed to EKS Blueprints Test April 11, 2023 16:57 — with GitHub Actions Inactive
@bryantbiggs bryantbiggs temporarily deployed to EKS Blueprints Test April 11, 2023 18:34 — with GitHub Actions Inactive
askulkarni2
askulkarni2 approved these changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@askulkarni2 askulkarni2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bryantbiggs bryantbiggs merged commit 531eb42 into main Apr 11, 2023
@bryantbiggs bryantbiggs deleted the refactor/multi-tenancy branch April 11, 2023 19:38
gminiba pushed a commit to gminiba/terraform-aws-eks-blueprints that referenced this pull request May 26, 2023
@bryantbiggs
refactor: Update teams multi-tenancy example to use new module (aws-i…
f041a1b 
…a#1549)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@askulkarni2 askulkarni2 askulkarni2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bryantbiggs @askulkarni2