Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update VPC module to v4, update EKS module to latest minor version #1546

Merged
merged 1 commit into from
Apr 7, 2023
Merged

chore: Update VPC module to v4, update EKS module to latest minor version #1546

merged 1 commit into from
Apr 7, 2023

Conversation

bryantbiggs
Copy link
Contributor

What does this PR do?

  • Update VPC module to v4, update EKS module to latest minor version

Motivation

  • The VPC module v4 was just released which simplifies the default settings

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@bryantbiggs bryantbiggs requested a review from a team as a code owner April 7, 2023 17:12
@bryantbiggs bryantbiggs temporarily deployed to EKS Blueprints Test April 7, 2023 17:12 — with GitHub Actions Inactive
@bryantbiggs
Copy link
Contributor Author

will need terraform-aws-modules/terraform-aws-vpc#920

askulkarni2
askulkarni2 approved these changes Apr 7, 2023
View reviewed changes
Copy link
Contributor

@askulkarni2 askulkarni2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍻

@bryantbiggs bryantbiggs temporarily deployed to EKS Blueprints Test April 7, 2023 19:59 — with GitHub Actions Inactive
@bryantbiggs bryantbiggs merged commit 01574aa into main Apr 7, 2023
@bryantbiggs bryantbiggs deleted the chore/update-vpc branch April 7, 2023 20:00
@askulkarni2 askulkarni2 mentioned this pull request Apr 7, 2023
Merged
5 tasks
gminiba pushed a commit to gminiba/terraform-aws-eks-blueprints that referenced this pull request May 26, 2023
@bryantbiggs
chore: Update VPC module to v4, update EKS module to latest minor ver…
74762f8 
…sion (aws-ia#1546)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@askulkarni2 askulkarni2 askulkarni2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bryantbiggs @askulkarni2