Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add local copy of Ondat due to Ondat repository migration #1523

Merged
merged 2 commits into from
Mar 30, 2023

Conversation

bryantbiggs
Copy link
Contributor

What does this PR do?

  • Add local copy of Ondat due to Ondat repository migration

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@bryantbiggs bryantbiggs requested a review from a team as a code owner March 30, 2023 12:47
@bryantbiggs bryantbiggs temporarily deployed to EKS Blueprints Test March 30, 2023 12:47 — with GitHub Actions Inactive
@kedare
Copy link

kedare commented Mar 30, 2023

Thanks for the PR :)
Will there be a new tag set once this is released ? As v4.26.0 is broken for now

@bryantbiggs
Copy link
Contributor Author

yes, we'll get a patch tag up as soon as this is merged. Then we'll have to figure out what the heck happened here

Copy link
Contributor

@askulkarni2 askulkarni2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bryantbiggs bryantbiggs temporarily deployed to EKS Blueprints Test March 30, 2023 13:18 — with GitHub Actions Inactive
@dcristobalhMad
Copy link

yes, we'll get a patch tag up as soon as this is merged. Then we'll have to figure out what the heck happened here

Hi @bryantbiggs , it means I will need to upgrade all blueprint modules of all my clusters to the new tag, right?

@bryantbiggs bryantbiggs merged commit 12e4395 into main Mar 30, 2023
@bryantbiggs bryantbiggs deleted the fix/ondat branch March 30, 2023 13:46
@bryantbiggs
Copy link
Contributor Author

@dcristobalhMad correct - since the source URL for Ondat is baked into the prior releases, you will need to update to at least v4.27.0 to get around this issue. Apologies for the inconvenience, we'll need to dig in to figure out why this occurred. Going forward in v5, we will no longer have, or allow, these dependencies

@mattduguid
Copy link

We just started getting these errors in azure devops pipelines this morning for our eks blueprints solution, we switched to v4.27.0 and has resolved thanks

Error: Failed to download module
│ 
│ Could not download module "ondat"
│ (.terraform/modules/aws-eks-cluster.eks_blueprints_addons_core/modules/kubernetes-addons/main.tf:365)
│ source code from
│ "git::[https://github.com/ondat/terraform-eksblueprints-ondat-addon?ref=0.1.2"](https://github.com/ondat/terraform-eksblueprints-ondat-addon?ref=0.1.2%22):
│ error downloading
│ '[https://github.com/ondat/terraform-eksblueprints-ondat-addon?ref=0.1.2'](https://github.com/ondat/terraform-eksblueprints-ondat-addon?ref=0.1.2%27):
│ /usr/bin/git exited with 128: Cloning into
│ '.terraform/modules/aws-eks-cluster.eks_blueprints_addons_core.ondat'...
│ fatal: could not read Username for '[https://github.com'](https://github.com%27/): terminal prompts
│ disabled

@brayan9413
Copy link

Hi @bryantbiggs one question
is it going to work later? I mean unlock the repo https://github.com/ondat/terraform-eksblueprints-ondat-addon

I have an old version of EKS blueprints, it's complicated to upgrade right now

@bryantbiggs
Copy link
Contributor Author

I don't know what is going on with the Ondat repo. What you can do in the interim is to fork the project at the version you are currently using and delete the Ondat resources from the project and use that fork for now until you can update to v4.27.0+

@bryantbiggs bryantbiggs mentioned this pull request Mar 30, 2023
1 task
@prtkdave
Copy link

Is there any patch released for older version? Please let us know, older versions are failing.

@bryantbiggs
Copy link
Contributor Author

No, there isn't any means of backporting patches to prior releases

@rkrao89
Copy link

rkrao89 commented Apr 3, 2023

We need a PR to update this to 4.27.0. I don't have permissions to push changes. https://github.com/awslabs/data-on-eks/blob/0641f798967599183901b0d2a2add67a3501f379/analytics/terraform/spark-k8s-operator/addons.tf#L2

@vara-bonthu
Copy link
Contributor

We need a PR to update this to 4.27.0. I don't have permissions to push changes. https://github.com/awslabs/data-on-eks/blob/0641f798967599183901b0d2a2add67a3501f379/analytics/terraform/spark-k8s-operator/addons.tf#L2

This blueprint has now been updated to use the latest V5 blueprints approach in Data on EKS.

awslabs/data-on-eks#170

gminiba pushed a commit to gminiba/terraform-aws-eks-blueprints that referenced this pull request Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ondat is migrating, breaking terraform init
9 participants