Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove variable validation - its causing more issues than value #1521

Merged
merged 1 commit into from
Mar 29, 2023
Merged

fix: Remove variable validation - its causing more issues than value #1521

merged 1 commit into from
Mar 29, 2023

Conversation

bryantbiggs
Copy link
Contributor

What does this PR do?

  • Remove variable validation - its causing more issues than value

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@bryantbiggs bryantbiggs requested a review from a team as a code owner March 29, 2023 22:52
@bryantbiggs bryantbiggs temporarily deployed to EKS Blueprints Test March 29, 2023 22:52 — with GitHub Actions Inactive
askulkarni2
askulkarni2 approved these changes Mar 29, 2023
View reviewed changes
Copy link
Contributor

@askulkarni2 askulkarni2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kol-ratner
Copy link

@bryantbiggs obviously this is up to you guys, but all thats needed in line 14 is a period at the end of the error message, you dont have to throw the whole idea away, a little bit of security isnt a bad thing, i think the spirit of this change is coming from the right place :)

@bryantbiggs
Copy link
Contributor Author

bryantbiggs commented Mar 29, 2023 •
edited
Loading

I think its something we can reconsider in the future with more testing and validation. for now though, its causing more harm than good (see preceding issues/PRs before this latest issue with punctuation)

@bryantbiggs bryantbiggs merged commit d72de41 into main Mar 29, 2023
@bryantbiggs bryantbiggs deleted the fix/remove-validation branch March 29, 2023 23:17
gminiba pushed a commit to gminiba/terraform-aws-eks-blueprints that referenced this pull request Apr 3, 2023
@bryantbiggs
fix: Remove variable validation - its causing more issues than value (a…
eb945af 
…ws-ia#1521)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@askulkarni2 askulkarni2 askulkarni2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid validation error message
3 participants
@bryantbiggs @kol-ratner @askulkarni2