fix: Escape regex validation backslash #1518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naxgrp-johnthompson
temporarily deployed
to
EKS Blueprints Test
GitHub Actions
Inactive
|
can you provide supporting evidence that shows its currently invalid? |
|
I did run into this error as well, so I believe this PR should help.
|
|
terraform first tries to escape the string before it parses the regex, so you need to escape the escape character. |
|
this is affecting production for a major aws migration effort for Sovrn as well, please push this through |
|
We are looking into it, as a best practice please pin your module usage to the latest released version, in this case |
bryantbiggs
approved these changes
Mar 29, 2023
gminiba
pushed a commit
to gminiba/terraform-aws-eks-blueprints
that referenced
this pull request
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This fixes a recent change that broke the argocd addon variables file -- i escaped the backslash before the dot so that it's a valid regex.