-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add validation on argocd_applications app name #1513
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catmand00
had a problem deploying
to
EKS Blueprints Test
March 27, 2023 16:06
— with
GitHub Actions
Error
catmand00
changed the title
feat: add validation on argocd_applications app name
feat: Add validation on argocd_applications app name
Mar 27, 2023
catmand00
had a problem deploying
to
EKS Blueprints Test
March 27, 2023 18:11
— with
GitHub Actions
Error
catmand00
had a problem deploying
to
EKS Blueprints Test
March 27, 2023 18:37
— with
GitHub Actions
Error
catmand00
had a problem deploying
to
EKS Blueprints Test
March 27, 2023 18:40
— with
GitHub Actions
Error
bryantbiggs
reviewed
Mar 29, 2023
bryantbiggs
had a problem deploying
to
EKS Blueprints Test
March 29, 2023 18:14
— with
GitHub Actions
Error
bryantbiggs
approved these changes
Mar 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
@catmand00 would you mind opening the same PR in our new addons repo https://github.com/aws-ia/terraform-aws-eks-blueprints-addons when you get a chance - thank you! |
bryantbiggs
had a problem deploying
to
EKS Blueprints Test
March 29, 2023 18:16
— with
GitHub Actions
Failure
gminiba
pushed a commit
to gminiba/terraform-aws-eks-blueprints
that referenced
this pull request
Apr 3, 2023
Co-authored-by: Bryant Biggs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The direction for EKS Blueprints will soon shift from providing an all-encompassing, monolithic "framework" and instead focus more on how users can organize a set of modular components to create the desired solution on Amazon EKS. We have updated the examples to show how we use the https://github.com/terraform-aws-modules/terraform-aws-eks for EKS cluster and node group creation. We will not be accepting any PRs that apply to EKS cluster or node group creation process. Any such PR may be closed by the maintainers.
We are hitting also the pause button on new add-on creations at this time until a future roadmap for add-ons is finalized. Please do not submit new add-on PRs. Any such PR may be closed by the maintainers.
Please track progress, learn what's new and how the migration path would look like to upgrade your current Terraform deployments. We welcome the EKS Blueprints community to continue the discussion in issue #1421
What does this PR do?
Add validation to the
var.applications
variable used byargocd
submodule, which uses thevar.argocd_applications
variable from the root module. The allowed name of the key is restricted by the same restrictions on kubernetes pod names, since the key is used for the name for the Application object, and the Application uses its name as the prefix of the resulting pod.🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.
Motivation
More
pre-commit run -a
with this PRFor Moderators
Additional Notes
I have tested this locally using the same config that resulted in an error (linked in the related Issue), and I receive the error during the plan phase instead (as intended). Changing the name to
test-app
passes the validation (also intended).